Add score filtering #634
Merged
Add score filtering #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I just rebased this against the current state of the development branch to make sure some of the failed tests are fixed. Could you please add tests that cover your new additions to the best of your ability. If you can't, comment here and I will do so when I have time. |
|
feel free to add tests. I doubt PRAW will rename these properties but you'd want to know if they ever do |
|
It's less a matter of PRAW changing and an interest in maintaining coverage. New features should be covered by tests. I'll write some when I have time then. |
Serene-Arc
force-pushed
the
patch-4
branch
2 times, most recently
from
ac7b1d3 to
2df68a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #630