Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imgur updates #664

Merged
merged 4 commits into from
Sep 20, 2022
Merged

Imgur updates #664

merged 4 commits into from
Sep 20, 2022

Conversation

Soulsuck24
Copy link
Contributor

Update Imgur logic to cover malformed links that cause a redirect leading to the html of the page being saved as an image.

Fixes #662

Update Imgur logic to cover malformed links that cause a redirect leading to the html of the page being saved as an image.
@KylarZeppeli
Copy link

Just checked this out & it looks like Imgur & RedGifs are working perfectly now, the 2 links I posted now download properly, & RedGifs was already fixed.
I'm new to GitHub, what has to happen to make your edits be part of the main repo?

@Serene-Arc
Copy link
Owner

I have to check it and merge it. I'm busy with studies at the moment but I'm going to try merging a bunch of stuff and doing a release in the next few days.

@KylarZeppeli
Copy link

KylarZeppeli commented Sep 19, 2022

Forgive me if this isn't how it works but the bdfr/site_downloaders/download_factory.py file from this pull request has made the RedGifs redirect links download as HTML with .jpg extensions again. (Imgur works perfectly)
I replaced it with the download_factory.py file from Soulsuck24@2f2b5b7
The one from there has every Imgur link download as HTML with .gifv extension. (RedGifs works perfectly)

@Soulsuck24
Copy link
Contributor Author

This only contains the Imgur changes so to have both you will need to manually combine the changes from both until Serene can check over them herself and merge them both.

@KylarZeppeli
Copy link

If that's the case then I believe you should be completely done with RedGifs & Imgur now as I have downloaded around 26,000 images from 45 subreddits again & every single file was correctly downloaded except for 56 links from RedGifs being downloaded as HTML with .jpg extension.
If that is fixed after the merge then everything should be 100% perfect.
Thanks for your help!

@Serene-Arc Serene-Arc merged commit 398f7b2 into Serene-Arc:development Sep 20, 2022
@Soulsuck24 Soulsuck24 deleted the imgur branch September 20, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Imgur redirection causing html page download
3 participants