Add soft fail on 5xx Prawcore errors. #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can use the patch function from the unit testing function to manually through a praw exception for the test to simulate the server messing up. |
I can't seem to get patch to work for me in the way I need to for this (or at least how I'm trying?). I can get it to raise the exception directly but not indirectly where it shows these catching the exception. So any help you can give would be much appreciated. |
|
Sure I'll take a look and add the tests to this PR. |
OMEGARAZER
force-pushed
the
development
branch
from
8e38f1a to
4ba5df6
Compare
|
Oh cool did you get them to work? |
|
It appears so, If I remove my original patches the tests fail, killing BDFR but tests pass with them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds except to stop 5xx errors killing run when going through user/submission lists.
Wasn't able to figure out how to write a test for this as it's an intermittent issue and not one we can knowingly get like 4xx errors. Been running with it for a few days and it's been working well though.
Also reduces some log spam by only printing the user being fetched rather than the whole list.