Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redgifs fix #726

Merged
merged 1 commit into from
Dec 20, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions bdfr/site_downloaders/redgifs.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ def find_resources(self, authenticator: Optional[SiteAuthenticator] = None) -> l
@staticmethod
def _get_link(url: str) -> set[str]:
try:
if url.endswith("/"):
url = url.removesuffix("/")
redgif_id = re.match(r".*/(.*?)(\..{0,})?$", url).group(1)
except AttributeError:
raise SiteDownloaderError(f"Could not extract Redgifs ID from {url}")
Expand Down
1 change: 1 addition & 0 deletions tests/site_downloaders/test_redgifs.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
"UnripeUnkemptWoodpecker-large.jpg",
},
),
("https://www.redgifs.com/watch/genuineprivateguillemot/", {"GenuinePrivateGuillemot.mp4"}),
),
)
def test_get_link(test_url: str, expected: set[str]):
Expand Down