Gfycat API #769
Merged
Gfycat API #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OMEGARAZER
force-pushed
the
gfycat-api
branch
from
13330ec to
aa94483
Compare
Moves Gfycat to use API via site access key. Adds cachetools as dependency to reuse API keys for Gfycat/Redgifs at 95% of their TTL. Include tests to verify caching. Updates versions of requests/yt-dlp/black/isort/pytest. Added default timeout to requests calls. Adds validate-pyproject and blacken-docs to pre-commit as well as updates versions.
OMEGARAZER
force-pushed
the
gfycat-api
branch
from
aa94483 to
0e28c7e
Compare
|
Was there anything else needed for this or any input? |
|
@OMEGARAZER in the future, I'd prefer that you do these changes in separate PRs. Each of the lines in your summary should be a separate PR as they are unrelated. Moving forwards I won't merge PRs like this because they really confuse the process and git history. They also make reviewing PRs a lot harder, fyi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves Gfycat to use API via site access key.
Adds cachetools as dependency to reuse API keys for Gfycat/Redgifs at 95% of their TTL. Include tests to verify caching.
Updates versions of requests/yt-dlp/black/isort/pytest.
Added default timeout to requests calls.
Adds validate-pyproject and blacken-docs to pre-commit as well as updates versions.