Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LibJS: Add %TypedArray%.prototype.with #14644

Merged
merged 2 commits into from
Jul 22, 2022
Merged

LibJS: Add %TypedArray%.prototype.with #14644

merged 2 commits into from
Jul 22, 2022

Conversation

beesaferoot
Copy link
Contributor

No description provided.

@beesaferoot beesaferoot changed the title Add %TypedArray%.prototype.with LibJS: Add %TypedArray%.prototype.with Jul 22, 2022
linusg
linusg reviewed Jul 22, 2022
View reviewed changes
Copy link
Member

@linusg linusg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :)

also, FYI: tc39/proposal-change-array-by-copy#88 (comment)

Userland/Libraries/LibJS/Runtime/TypedArrayPrototype.cpp Show resolved Hide resolved
Userland/Libraries/LibJS/Runtime/TypedArrayPrototype.cpp Outdated Show resolved Hide resolved
Userland/Libraries/LibJS/Runtime/TypedArrayPrototype.cpp Outdated Show resolved Hide resolved
@beesaferoot
Copy link
Contributor Author

also, FYI: tc39/proposal-change-array-by-copy#88 (comment)

Oh okay, looks like I'll have to nuke it myself :(

@beesaferoot
Copy link
Contributor Author

Updated, following review comments. Kindly review :)

linusg
linusg approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@linusg linusg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (let's wait with the toSpliced removal until they've actually done it so we have a commit to reference)

@linusg linusg merged commit 9956d3d into SerenityOS:master Jul 22, 2022
@linusg linusg mentioned this pull request Dec 7, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linusg linusg linusg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beesaferoot @linusg