Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Userland: Port a few applications to the GML compiler #20524

Merged
merged 7 commits into from
Jan 19, 2024
Merged

Userland: Port a few applications to the GML compiler #20524

merged 7 commits into from
Jan 19, 2024

Conversation

kleinesfilmroellchen
Copy link
Collaborator

CertificateSettings, CalendarSettings, Calendar, Calculator, BrowserSettings, Run, LoginServer. All confirmed to work.

Depends on #20523

@kleinesfilmroellchen kleinesfilmroellchen changed the title Userland: Port a few applications to new GML Userland: Port a few applications to the GML compiler Aug 12, 2023
@kleinesfilmroellchen kleinesfilmroellchen marked this pull request as ready for review August 12, 2023 20:35
@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Aug 12, 2023
@kleinesfilmroellchen kleinesfilmroellchen mentioned this pull request Aug 13, 2023
Open
47 tasks
@stale
Copy link

stale bot commented Sep 13, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

@stale stale bot added the stale label Sep 13, 2023
@gmta gmta added ⚠️ pr-has-conflicts PR has merge conflicts and needs to be rebased and removed 👀 pr-needs-review PR needs review from a maintainer or community member labels Oct 1, 2023
@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Oct 1, 2023
@kleinesfilmroellchen kleinesfilmroellchen removed the ⚠️ pr-has-conflicts PR has merge conflicts and needs to be rebased label Oct 1, 2023
@gmta
Copy link
Member

gmta commented Oct 2, 2023

Linter is failing in CI.

@gmta gmta added the ⏳ pr-waiting-for-author PR is blocked by feedback / code changes from the author label Oct 2, 2023
@github-actions github-actions bot removed the ⏳ pr-waiting-for-author PR is blocked by feedback / code changes from the author label Oct 3, 2023
@kleinesfilmroellchen kleinesfilmroellchen force-pushed the run-gml branch 2 times, most recently from ad98116 to 8d5e224 Compare October 3, 2023 11:43
timschumi
timschumi requested changes Oct 10, 2023
View reviewed changes
Userland/Applications/BrowserSettings/AutoplaySettingsWidget.h Outdated Show resolved Hide resolved
Userland/Applications/BrowserSettings/BrowserSettingsWidget.h Outdated Show resolved Hide resolved
Userland/Applications/BrowserSettings/ContentFilterSettingsWidget.h Outdated Show resolved Hide resolved
Userland/Applications/Calculator/CalculatorWidget.h Show resolved Hide resolved
Userland/Applications/BrowserSettings/AutoplaySettingsWidget.h Outdated Show resolved Hide resolved
Userland/Applications/BrowserSettings/BrowserSettingsWidget.h Outdated Show resolved Hide resolved
Userland/Applications/BrowserSettings/ContentFilterSettingsWidget.h Outdated Show resolved Hide resolved
Userland/Applications/Calculator/CalculatorWidget.h Outdated Show resolved Hide resolved
Userland/Applications/CertificateSettings/CertificateStoreWidget.h Outdated Show resolved Hide resolved
@timschumi
Copy link
Member

Addendum: Looks like we have a multitude of established ways to run additional initialization functions after the GML part has been initialized. Maybe we should look at hooking this into the GML compiler in the future (most likely thinking up one "true" interface and placing if constexpr (requires { MyCoolWidget::cool_initialization_function() }) in the generated code).

@kleinesfilmroellchen
Copy link
Collaborator Author

Addendum: Looks like we have a multitude of established ways to run additional initialization functions after the GML part has been initialized. Maybe we should look at hooking this into the GML compiler in the future (most likely thinking up one "true" interface and placing if constexpr (requires { MyCoolWidget::cool_initialization_function() }) in the generated code).

This is a good idea, but I think we can move forward with this anyways.

@kleinesfilmroellchen kleinesfilmroellchen mentioned this pull request Oct 10, 2023
Closed
@stale Stale
Copy link

stale bot commented Nov 1, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

@stale stale bot added the stale label Nov 1, 2023
@stale Stale
Copy link

stale bot commented Nov 8, 2023

This pull request has been closed because it has not had recent activity. Feel free to re-open if you wish to still contribute these changes. Thank you for your contributions!

@stale stale bot closed this Nov 8, 2023
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label Nov 8, 2023
@timschumi timschumi self-requested a review November 8, 2023 17:12
@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Nov 8, 2023
@stale stale bot removed stale labels Nov 8, 2023
timschumi
timschumi approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@timschumi timschumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needs a rebase.

@stale Stale
Copy link

stale bot commented Dec 8, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

@stale stale bot added the stale label Dec 8, 2023
@stale Stale
Copy link

stale bot commented Dec 15, 2023

This pull request has been closed because it has not had recent activity. Feel free to re-open if you wish to still contribute these changes. Thank you for your contributions!

@stale stale bot closed this Dec 15, 2023
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label Dec 15, 2023
@stale stale bot removed the stale label Jan 5, 2024
@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Jan 5, 2024
@ADKaster
Copy link
Member

(still needs a rebase)

conflicts with apps that other contributors updated in the meantime.

@ADKaster ADKaster added the ⚠️ pr-has-conflicts PR has merge conflicts and needs to be rebased label Jan 13, 2024
@ADKaster ADKaster added ✅ pr-maintainer-approved-but-awaiting-ci PR has been approved by a maintainer and can be merged after CI has passed and removed 👀 pr-needs-review PR needs review from a maintainer or community member ⚠️ pr-has-conflicts PR has merge conflicts and needs to be rebased labels Jan 19, 2024
@AtkinsSJ AtkinsSJ merged commit 3afbf66 into SerenityOS:master Jan 19, 2024
13 checks passed
@github-actions github-actions bot removed the ✅ pr-maintainer-approved-but-awaiting-ci PR has been approved by a maintainer and can be merged after CI has passed label Jan 19, 2024
@kleinesfilmroellchen kleinesfilmroellchen deleted the run-gml branch January 19, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timschumi timschumi timschumi approved these changes

@ADKaster ADKaster ADKaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kleinesfilmroellchen @gmta @timschumi @ADKaster @AtkinsSJ