Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TerminalSettings: Port to GML Compiler #22512

Merged
merged 5 commits into from
Jan 19, 2024
Merged

TerminalSettings: Port to GML Compiler #22512

merged 5 commits into from
Jan 19, 2024
+196 −149

Conversation

mrunix00
Copy link
Contributor

Contributes to: #20518

@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Dec 31, 2023
@timschumi timschumi self-requested a review January 2, 2024 01:23
@timschumi timschumi mentioned this pull request Jan 9, 2024
Open
47 tasks
timschumi
timschumi requested changes Jan 9, 2024
View reviewed changes
Meta/Lagom/Tools/CodeGenerators/GMLCompiler/main.cpp Outdated Show resolved Hide resolved
Userland/Libraries/LibGUI/Frame.h Outdated Show resolved Hide resolved
Meta/Lagom/Tools/CodeGenerators/GMLCompiler/main.cpp Outdated Show resolved Hide resolved
Userland/Applications/TerminalSettings/CMakeLists.txt Outdated Show resolved Hide resolved
@ADKaster ADKaster added ⏳ pr-waiting-for-author PR is blocked by feedback / code changes from the author and removed 👀 pr-needs-review PR needs review from a maintainer or community member labels Jan 14, 2024
@mrunix00 mrunix00 marked this pull request as draft January 18, 2024 11:38
@github-actions github-actions bot removed the ⏳ pr-waiting-for-author PR is blocked by feedback / code changes from the author label Jan 18, 2024
@mrunix00 mrunix00 force-pushed the terminal-settings-gml-compiler branch 2 times, most recently from 64bc88a to 11c2cb7 Compare January 18, 2024 14:14
@mrunix00 mrunix00 marked this pull request as ready for review January 18, 2024 14:14
@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Jan 18, 2024
@mrunix00 mrunix00 force-pushed the terminal-settings-gml-compiler branch from 11c2cb7 to be1ee67 Compare January 18, 2024 15:00
@timschumi timschumi force-pushed the terminal-settings-gml-compiler branch from be1ee67 to 90f2038 Compare January 19, 2024 15:23
@timschumi
Copy link
Member

Rebased onto latest master to resolve minor merge conflicts in GMLCompiler, no changes.

@timschumi timschumi added ✅ pr-maintainer-approved-but-awaiting-ci PR has been approved by a maintainer and can be merged after CI has passed and removed 👀 pr-needs-review PR needs review from a maintainer or community member labels Jan 19, 2024
@timschumi timschumi merged commit 2440a2f into SerenityOS:master Jan 19, 2024
11 of 13 checks passed
@timschumi timschumi removed the ✅ pr-maintainer-approved-but-awaiting-ci PR has been approved by a maintainer and can be merged after CI has passed label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timschumi timschumi timschumi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrunix00 @timschumi @ADKaster