Meta: Use response file for linking shared libraries in GN build #25571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linking liblagom-web.so produces a ~132K long command line. Ninja passes the whole command line as a single arg to `sh -c <arg>`, and the limit for single arguments (`MAX_ARG_STRLEN`) on Linux is `PAGE_SIZE * 32` == 128K. A response file passes the list of files in a file on disk, which lets us sidestep this problem. Ninja writes response files before invoking commands, and deletes them after (unless `-d keeprsp` is passed to ninja, then it keeps them on disk).
github-actions
bot
added
the
👀 pr-needs-review
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linking liblagom-web.so produces a ~132K long command line. Ninja passes the whole command line as a single arg to
sh -c <arg>, and the limit for single arguments (MAX_ARG_STRLEN) on Linux isPAGE_SIZE * 32== 128K.A response file passes the list of files in a file on disk, which lets us sidestep this problem. Ninja writes response files before invoking commands, and deletes them after (unless
-d keeprspis passed to ninja, then it keeps them on disk).