Add file lock to support mutli processes usage

Pipfile

@@ -19,3 +19,4 @@ mock = "*"
 requests = "*"
 python-dotenv = "*"
 packaging = "*"
+filelock = "*"

setup.py

@@ -48,7 +48,8 @@
  install_requires=[
  'requests',
  'python-dotenv',
- 'packaging'
+ 'packaging',
+ 'filelock'
  ],
  package_data={
  "webdriver_manager": ["py.typed"]

tests/test_multi_processes.py

@@ -0,0 +1,22 @@
+from concurrent.futures import ProcessPoolExecutor
+from selenium import webdriver
+from selenium.webdriver.chrome.service import Service
+from selenium.webdriver.chrome.options import Options
+from webdriver_manager.chrome import ChromeDriverManager
+
+
+def _run(_):
+ chromedriver_path = ChromeDriverManager().install()
+ chrome_options = Options()
+ chrome_options.add_argument('--headless=new')
+ chrome_options.add_argument('--disable-gpu')
+ driver = webdriver.Chrome(service=Service(chromedriver_path), options=chrome_options)
+ url = 'https://www.google.com'
+ driver.set_page_load_timeout(10)
+ driver.get(url)
+ driver.quit()
+
+
+def test_install_driver_in_multi_processes(delete_drivers_dir):
+ pool = ProcessPoolExecutor(max_workers=5)
+ assert list(pool.map(_run, range(5)))

webdriver_manager/core/manager.py

@@ -1,7 +1,10 @@
+import os
+from filelock import FileLock
 from webdriver_manager.core.download_manager import WDMDownloadManager
 from webdriver_manager.core.driver_cache import DriverCacheManager
 from webdriver_manager.core.logger import log
 from webdriver_manager.core.os_manager import OperationSystemManager
+from webdriver_manager.core.constants import DEFAULT_USER_HOME_CACHE_PATH
 
 
 class DriverManager(object):
@@ -32,14 +35,16 @@ def install(self) -> str:
  raise NotImplementedError("Please Implement this method")
 
  def _get_driver_binary_path(self, driver):
- binary_path = self._cache_manager.find_driver(driver)
- if binary_path:
+ file_lock = FileLock(os.path.join(DEFAULT_USER_HOME_CACHE_PATH, "drivers.json.lock"))
+ with file_lock:
+ binary_path = self._cache_manager.find_driver(driver)
+ if binary_path:
+ return binary_path
+
+ os_type = self.get_os_type()
+ file = self._download_manager.download_file(driver.get_driver_download_url(os_type))
+ binary_path = self._cache_manager.save_file_to_cache(driver, file)
  return binary_path
 
- os_type = self.get_os_type()
- file = self._download_manager.download_file(driver.get_driver_download_url(os_type))
- binary_path = self._cache_manager.save_file_to_cache(driver, file)
- return binary_path
-
  def get_os_type(self):
  return self._os_system_manager.get_os_type()