Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use win64 for newer Chromedriver versions #647

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use win64 for newer Chromedriver versions #647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion webdriver_manager/chrome.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import os
from packaging import version
from typing import Optional

from webdriver_manager.core.download_manager import DownloadManager
Expand Down Expand Up @@ -26,6 +27,7 @@ def __init__(
os_system_manager=os_system_manager
)

self.driver_version = driver_version
self.driver = ChromeDriver(
name=name,
driver_version=driver_version,
Expand All @@ -44,7 +46,10 @@ def install(self) -> str:
def get_os_type(self):
os_type = super().get_os_type()
if "win" in os_type:
return "win32"
if version.parse(self.driver_version) >= version.parse("115"):
return os_type
else:
return "win32"

if not self._os_system_manager.is_mac_os(os_type):
return os_type
Expand Down
Loading