Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix __get_binary by excluding third party licenses #666

Conversation

Jheesbrough
Copy link
Contributor

@Jheesbrough Jheesbrough commented Jul 24, 2024

Add an exclusion for files containing THIRD_PARTY when retrieving for the driver binary

Fixing #663
and duplicates:
#664
#665

@broberts19
Copy link

I tested this fix and it works. Please merge it.

@jacobfelknor
Copy link

According to the README, the main project maintainer has put this project on hold. Are there additional maintainers who are able to complete this PR? Just checking before I fork.....

@SergeyPirogov SergeyPirogov merged commit 3280b00 into SergeyPirogov:master Jul 25, 2024
2 of 5 checks passed
@ggkiokas
Copy link

Can you please let us know how we can have this fix in a specific version of webdriver-manager ?

@GaryPerkins
Copy link

Can you please let us know how we can have this fix in a specific version of webdriver-manager ?

looks like a new release is available - 4.0.2

thanks all for the quick turnaround on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants