Add unit tests for new analyzer

Sergio0694 · Dec 20, 2024 · 36c4043 · 36c4043
1 parent 83c598d
commit 36c4043
Show file tree

Hide file tree

Showing 2 changed files with 228 additions and 1 deletion.
diff --git a/...ators/Diagnostics/Analyzers/UseGeneratedCanvasEffectPropertyOnSemiAutoPropertyAnalyzer.cs b/...ators/Diagnostics/Analyzers/UseGeneratedCanvasEffectPropertyOnSemiAutoPropertyAnalyzer.cs
@@ -229,7 +229,7 @@ public override void Initialize(AnalysisContext context)
                         }
 
                         // The invalidation mode can either be the default value...
-                        if (invalidationModeArgument is not { IsImplicit: true, ArgumentKind: ArgumentKind.DefaultValue })
+                        if (invalidationModeArgument is { IsImplicit: true, ArgumentKind: ArgumentKind.DefaultValue })
                         {
                             validFlags[1] = 1;
                         }

diff --git a/...teSharp.D2D1.WinUI.Tests.SourceGenerators/Test_CanvasEffectPropertyGenerator_Analyzers.cs b/...teSharp.D2D1.WinUI.Tests.SourceGenerators/Test_CanvasEffectPropertyGenerator_Analyzers.cs
@@ -227,4 +227,231 @@ public abstract partial class MyEffect : CanvasEffect
 
         await CSharpAnalyzerWithLanguageVersionTest<RequireCSharpLanguageVersionPreviewAnalyzer>.VerifyAnalyzerAsync(source, languageVersion: LanguageVersion.Preview);
     }
+
+    [TestMethod]
+    public async Task UseGeneratedCanvasEffectPropertyOnSemiAutoPropertyAnalyzer_NormalProperty_DoesNotWarn()
+    {
+        const string source = """
+            using ComputeSharp.D2D1.WinUI;
+
+            public abstract partial class SampleCanvasEffect : CanvasEffect
+            {
+                public string Name { get; set; }
+            }
+            """;
+
+        await CSharpAnalyzerWithLanguageVersionTest<UseGeneratedCanvasEffectPropertyOnSemiAutoPropertyAnalyzer>.VerifyAnalyzerAsync(source, languageVersion: LanguageVersion.Preview);
+    }
+
+    [TestMethod]
+    public async Task UseGeneratedCanvasEffectPropertyOnSemiAutoPropertyAnalyzer_SimilarProperty_NotObservableObject_DoesNotWarn()
+    {
+        const string source = """
+            using ComputeSharp.D2D1.WinUI;
+
+            public abstract partial class SampleCanvasEffect : MyBaseCanvasEffect
+            {
+                public string Name
+                {
+                    get => field;
+                    set => SetPropertyAndInvalidateEffectGraph(ref field, value);
+                }
+            }
+
+            public abstract class MyBaseCanvasEffect
+            {
+                protected void SetPropertyAndInvalidateEffectGraph<T>(ref T location, T value, CanvasEffectInvalidationType invalidationType = CanvasEffectInvalidationType.Update)
+                {
+                }
+            }
+            """;
+
+        await CSharpAnalyzerWithLanguageVersionTest<UseGeneratedCanvasEffectPropertyOnSemiAutoPropertyAnalyzer>.VerifyAnalyzerAsync(source, languageVersion: LanguageVersion.Preview);
+    }
+
+    [TestMethod]
+    public async Task UseGeneratedCanvasEffectPropertyOnSemiAutoPropertyAnalyzer_NoGetter_DoesNotWarn()
+    {
+        const string source = """
+            using ComputeSharp.D2D1.WinUI;
+
+            public abstract partial class SampleCanvasEffect : CanvasEffect
+            {
+                public string Name
+                {
+                    set => SetPropertyAndInvalidateEffectGraph(ref field, value);
+                }
+            }
+            """;
+
+        await CSharpAnalyzerWithLanguageVersionTest<UseGeneratedCanvasEffectPropertyOnSemiAutoPropertyAnalyzer>.VerifyAnalyzerAsync(source, languageVersion: LanguageVersion.Preview);
+    }
+
+    [TestMethod]
+    public async Task UseGeneratedCanvasEffectPropertyOnSemiAutoPropertyAnalyzer_NoSetter_DoesNotWarn()
+    {
+        const string source = """
+            using ComputeSharp.D2D1.WinUI;
+
+            public abstract partial class SampleCanvasEffect : CanvasEffect
+            {
+                public string Name
+                {
+                    get => field;
+                }
+            }
+            """;
+
+        await CSharpAnalyzerWithLanguageVersionTest<UseGeneratedCanvasEffectPropertyOnSemiAutoPropertyAnalyzer>.VerifyAnalyzerAsync(source, languageVersion: LanguageVersion.Preview);
+    }
+
+    [TestMethod]
+    public async Task UseGeneratedCanvasEffectPropertyOnSemiAutoPropertyAnalyzer_OtherLocation_DoesNotWarn()
+    {
+        const string source = """
+            using ComputeSharp.D2D1.WinUI;
+
+            public abstract partial class SampleCanvasEffect : CanvasEffect
+            {
+                public string Name
+                {
+                    get => field;
+                    set
+                    {
+                        string test = field;
+
+                        SetPropertyAndInvalidateEffectGraph(ref test, value);
+                    }
+                }
+            }
+            """;
+
+        await CSharpAnalyzerWithLanguageVersionTest<UseGeneratedCanvasEffectPropertyOnSemiAutoPropertyAnalyzer>.VerifyAnalyzerAsync(source, languageVersion: LanguageVersion.Preview);
+    }
+
+    [TestMethod]
+    public async Task UseGeneratedCanvasEffectPropertyOnSemiAutoPropertyAnalyzer_OtherValue_DoesNotWarn()
+    {
+        const string source = """
+            using ComputeSharp.D2D1.WinUI;
+
+            public abstract partial class SampleCanvasEffect : CanvasEffect
+            {
+                public string Name
+                {
+                    get => field;
+                    set
+                    {
+                        string test = "Bob";
+
+                        SetPropertyAndInvalidateEffectGraph(ref field, test);
+                    }
+                }
+            }
+            """;
+
+        await CSharpAnalyzerWithLanguageVersionTest<UseGeneratedCanvasEffectPropertyOnSemiAutoPropertyAnalyzer>.VerifyAnalyzerAsync(source, languageVersion: LanguageVersion.Preview);
+    }
+
+    [TestMethod]
+    public async Task UseGeneratedCanvasEffectPropertyOnSemiAutoPropertyAnalyzer_ValidProperty_WithGeneratedCanvasEffectProperty_DoesNotWarn()
+    {
+        const string source = """
+            using ComputeSharp.D2D1.WinUI;
+
+            public abstract partial class SampleCanvasEffect : CanvasEffect
+            {
+                [GeneratedCanvasEffectProperty]
+                public string Name
+                {
+                    get => field;
+                    set => SetPropertyAndInvalidateEffectGraph(ref field, value);
+                }
+            }
+            """;
+
+        await CSharpAnalyzerWithLanguageVersionTest<UseGeneratedCanvasEffectPropertyOnSemiAutoPropertyAnalyzer>.VerifyAnalyzerAsync(source, languageVersion: LanguageVersion.Preview);
+    }
+
+    [TestMethod]
+    public async Task UseGeneratedCanvasEffectPropertyOnSemiAutoPropertyAnalyzer_GetAccessorWithExpressionBody_DoesNotWarn()
+    {
+        const string source = """
+            using ComputeSharp.D2D1.WinUI;
+
+            public abstract partial class SampleCanvasEffect : CanvasEffect
+            {
+                public string Name
+                {
+                    get => "Hello world";
+                    set => SetPropertyAndInvalidateEffectGraph(ref field, value);
+                }
+            }
+            """;
+
+        await CSharpAnalyzerWithLanguageVersionTest<UseGeneratedCanvasEffectPropertyOnSemiAutoPropertyAnalyzer>.VerifyAnalyzerAsync(source, languageVersion: LanguageVersion.Preview);
+    }
+
+    [TestMethod]
+    public async Task UseGeneratedCanvasEffectPropertyOnSemiAutoPropertyAnalyzer_ValidProperty_Warns()
+    {
+        const string source = """
+            using ComputeSharp.D2D1.WinUI;
+
+            public abstract partial class SampleCanvasEffect : CanvasEffect
+            {
+                public string {|CMPSD2DWINUI0008:Name|}
+                {
+                    get => field;
+                    set => SetPropertyAndInvalidateEffectGraph(ref field, value);
+                }
+            }
+            """;
+
+        await CSharpAnalyzerWithLanguageVersionTest<UseGeneratedCanvasEffectPropertyOnSemiAutoPropertyAnalyzer>.VerifyAnalyzerAsync(source, languageVersion: LanguageVersion.Preview);
+    }
+
+    [TestMethod]
+    public async Task UseGeneratedCanvasEffectPropertyOnSemiAutoPropertyAnalyzer_ValidProperty_WithModifiers_Warns()
+    {
+        const string source = """
+            using ComputeSharp.D2D1.WinUI;
+
+            public abstract partial class SampleCanvasEffect : CanvasEffect
+            {
+                public new string {|CMPSD2DWINUI0008:Name|}
+                {
+                    get => field;
+                    private set => SetPropertyAndInvalidateEffectGraph(ref field, value);
+                }
+            }
+            """;
+
+        await CSharpAnalyzerWithLanguageVersionTest<UseGeneratedCanvasEffectPropertyOnSemiAutoPropertyAnalyzer>.VerifyAnalyzerAsync(source, languageVersion: LanguageVersion.Preview);
+    }
+
+    [TestMethod]
+    public async Task UseGeneratedCanvasEffectPropertyOnSemiAutoPropertyAnalyzer_ValidProperty_WithBlocks_Warns()
+    {
+        const string source = """
+            using ComputeSharp.D2D1.WinUI;
+
+            public abstract partial class SampleCanvasEffect : CanvasEffect
+            {
+                public new string {|CMPSD2DWINUI0008:Name|}
+                {
+                    get
+                    {
+                        return field;
+                    }
+                    private set
+                    {
+                        SetPropertyAndInvalidateEffectGraph(ref field, value);
+                    }
+                }
+            }
+            """;
+
+        await CSharpAnalyzerWithLanguageVersionTest<UseGeneratedCanvasEffectPropertyOnSemiAutoPropertyAnalyzer>.VerifyAnalyzerAsync(source, languageVersion: LanguageVersion.Preview);
+    }
 }