Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix effect factory cache registration and validation logic #513

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

Sergio0694
Copy link
Owner

Description

This PR includes a couple follow up fixes for #512. Specifically:

  • Adds the missing registration for created wrappers into the Win2D cache
  • Ports the D2D factory validation logic from Win2D

@Sergio0694 Sergio0694 added the bug fix ✅ A fix for a reported/discovered bug label Apr 24, 2023
@Sergio0694 Sergio0694 merged commit 168fb8a into main Apr 24, 2023
@Sergio0694 Sergio0694 deleted the dev/fix-effect-factory branch April 24, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix ✅ A fix for a reported/discovered bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant