Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove shader compilation from reflection services, rename Dynamic library #622

Merged
merged 10 commits into from
Oct 17, 2023
Merged

Remove shader compilation from reflection services, rename Dynamic library #622

merged 10 commits into from
Oct 17, 2023

Conversation

Sergio0694
Copy link
Owner

Contributes to #598

Description

This PR includes several changes:

  • Adds the bytecode to ShaderInfo and D2D1ShaderInfo
  • Removes dynakmically compiling shaders in ReflectionServices, always use the precompiled bytecode
  • Remove leftover and unnecessary ReflectionServices overloads
  • Rename ComputeSharp.Dynamic to ComputeSharp.Dxc

@Sergio0694 Sergio0694 added enhancement ✨ An improvement to existing APIs optimization 🚀 Performance improvement to existing APIs refactoring 🧹 Code style and architecture improvements breaking change 💣 A change that is either binary or source breaking labels Oct 17, 2023
@Sergio0694 Sergio0694 merged commit 38c02e4 into main Oct 17, 2023
@Sergio0694 Sergio0694 deleted the dev/reflection-tweaks branch October 17, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change 💣 A change that is either binary or source breaking enhancement ✨ An improvement to existing APIs optimization 🚀 Performance improvement to existing APIs refactoring 🧹 Code style and architecture improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Sergio0694