Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove analytics service from WinUI sample app #840

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

Sergio0694
Copy link
Owner

Description

This PR removes the analytics sample from the WinUI sample app. This service was originally used Microsoft AppCenter, which is now long gone. The leftover code was always using the debug logger, which isn't really needed and just makes the code more complicated. This PR just removes all of it and the associated code with logging constants and messages.

@Sergio0694 Sergio0694 added the samples 📚 A change or improvement related to the samples label Aug 22, 2024
@Sergio0694 Sergio0694 merged commit 0ea1e3f into main Aug 22, 2024
24 checks passed
@Sergio0694 Sergio0694 deleted the dev/remove-analytics-service branch August 22, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples 📚 A change or improvement related to the samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant