Improve serde feature #12
Conversation
bevy-inspector-egui now works perfectly fine through Reflect, so no need to also derive inspector options when we don't use any of its annotations.
No need to force dependents to have the feature
|
|
||
| [features] | ||
| default = ["serialize"] | ||
| inspect = ["bevy-inspector-egui"] |
There was a problem hiding this comment.
Try not to modify the rest of the code, keep this feature so that there are no conflicts with the other PR's.
|
|
||
| [dependencies] | ||
| bevy = { version = "0.11" } |
| ] } | ||
| serde = { version = "^1", optional = true } | ||
|
|
||
| [build-dependencies] |
There was a problem hiding this comment.
Although I think the idea is great, I don't think it should go as a build dependency, because sometimes someone might need it in production or in some other way, so I think it should be kept as a feature base
There was a problem hiding this comment.
If they need the derive feature, they could just add it themselves? Why should we force it on them?
|
I've kept the prs in serial because they all conflict with one another. My plan was that you could merge the first one first, then i can rebase and you'll get a clean diff (or just look at the individual commits) |
|
(see depends on comments) |
I'm fine with that, however, I would like you to take into account the inspect |
|
Solved in #13 Thanks for your contribution 😄 |
serializetoserdeto follow conventions and rust API guidelines:https://rust-lang.github.io/api-guidelines/naming.html#feature-names-are-free-of-placeholder-words-c-feature
Depends on #11