-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT: CRUD API - DDB - EventPublisher #17
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Various comments. Overall, looks awesome!
templates/patterns/complete-patterns/cdk-crud-api-with-event-publisher/infra/lib/infra-stack.ts
Outdated
Show resolved
Hide resolved
...atterns/complete-patterns/cdk-crud-api-with-event-publisher/lambdas/delete-by-id/src/main.rs
Outdated
Show resolved
Hide resolved
...erns/complete-patterns/cdk-crud-api-with-event-publisher/lambdas/event-publisher/src/main.rs
Outdated
Show resolved
Hide resolved
...erns/complete-patterns/cdk-crud-api-with-event-publisher/lambdas/event-publisher/src/main.rs
Show resolved
Hide resolved
...erns/complete-patterns/cdk-crud-api-with-event-publisher/lambdas/event-publisher/src/main.rs
Show resolved
Hide resolved
...patterns/complete-patterns/cdk-crud-api-with-event-publisher/lambdas/delete-by-id/Cargo.toml
Show resolved
Hide resolved
...s/patterns/complete-patterns/cdk-crud-api-with-event-publisher/lambdas/get-by-id/src/main.rs
Show resolved
Hide resolved
...s/patterns/complete-patterns/cdk-crud-api-with-event-publisher/lambdas/get-by-id/src/main.rs
Outdated
Show resolved
Hide resolved
} | ||
} | ||
|
||
struct Order { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this not in it's own file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, fair point. I've put the Order and OrderRepository in the same file so that the Order can keep the fields private.
No description provided.