Benchmark.prepare_backend() #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@recursix that's a bit hacky but it should do for now |
recursix
reviewed
Oct 24, 2024
browsergym/experiments/src/browsergym/experiments/benchmark/base.py
Outdated
Show resolved
Hide resolved
recursix
reviewed
Oct 24, 2024
| @@ -55,6 +55,7 @@ class Benchmark(DataClassJsonMixin): | |||
| high_level_action_set_args: HighLevelActionSetArgs | |||
| is_multi_tab: bool | |||
| env_args_list: list[EnvArgs] | |||
| full_reset_script: Optional[str] | |||
There was a problem hiding this comment.
hmmm this is a symptom that we should have went with a class hieararchy instead of a single class for all benchmarks
recursix
reviewed
Oct 24, 2024
recursix
reviewed
Oct 24, 2024
| @@ -50,6 +53,29 @@ def __init__( | |||
|
|
|||
| self.credentials = ACCOUNTS | |||
|
|
|||
| def full_reset(self): | |||
There was a problem hiding this comment.
helper function instead of code duplicate?
There was a problem hiding this comment.
What do you mean code duplicate? This code is new
There was a problem hiding this comment.
it's 90% the same code on the side of visualwebarena
recursix
previously approved these changes
Oct 24, 2024
gasse
changed the title
full_reset_script
recursix
previously approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.