Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lean Unicode() gym space #218

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Lean Unicode() gym space #218

merged 2 commits into from
Oct 28, 2024

Conversation

gasse
Copy link
Collaborator

@gasse gasse commented Oct 28, 2024 •
edited
Loading

  • removed Unicode().min_length and Unicode().max_length
  • Unicode().sample() now raises NotImplementedError

Adresses #216

@gasse gasse changed the title Simplified Unicode() gym space Lean Unicode() gym space Oct 28, 2024
@gasse gasse mentioned this pull request Oct 28, 2024
Closed
@manuel-delverme
Copy link
Contributor

It's surprising you didn't need to explicitly disable it

@gasse
Copy link
Collaborator Author

gasse commented Oct 28, 2024

Thanks!

@gasse gasse merged commit 6da763a into main Oct 28, 2024
13 checks passed
@gasse gasse deleted the gasse/patch_55 branch October 28, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuel-delverme manuel-delverme manuel-delverme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gasse @manuel-delverme