Language model block #372
Merged
Language model block #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tscholak
approved these changes
Oct 6, 2025
| # TODO: Prevent unsafe by default | ||
| yield from torch.load(path) | ||
| # TODO: Confirm that loading works with `weights_only=True` | ||
| yield from torch.load(path, weights_only=True) |
There was a problem hiding this comment.
thanks for making our sec folks happy
| ModelTestingGroup.distributed: ModelTestingGroupAction.unimportant, | ||
| }, | ||
| ) | ||
| del MODEL_CONFIGS["starcoder_2"].config_dict["model"]["base_model"]["embeddings"]["num_position_embeddings"] |
There was a problem hiding this comment.
It's unused but leaving it in the dict caused errors when comparing with converted configs.
| # Set a dummy default user so we don't run in root by default. | ||
| # The image is still compatible with any user id. | ||
| RUN useradd user | ||
| USER user |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Description
A small follow-up to #370, turning the language model itself into a module just like any other. Also move the hidden size to the language model config to enforce that module input/output dimensions are set by their parent module.
Also added small safety tweaks.