Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type declaration for insert and update in GlideRecord is incorrect #102

Closed
heigum opened this issue Apr 9, 2024 · 0 comments
Closed

Type declaration for insert and update in GlideRecord is incorrect #102

heigum opened this issue Apr 9, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@heigum
Copy link

heigum commented Apr 9, 2024

Hi there, using 1.1.6 version of your lib to do some ServiceNow automation.

The methods insert and update on the GlideRecord are declared as

Optional(str)

This is incorrect they should have been declared as

Optional(GlideElement)

or made to return the sys_is as a str.
@vetsin vetsin added the bug Something isn't working label Apr 9, 2024
@vetsin vetsin closed this as completed in e65fff2 Apr 10, 2024
vetsin added a commit that referenced this issue Apr 10, 2024
@vetsin
Merge pull request #103 from ServiceNow/scratch/bug-fixes
39d6bcf 
fix: address #101 and #102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vetsin @heigum