Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added creation of Tag in repository #11

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

phifogg
Copy link

@phifogg phifogg commented Mar 24, 2021

Addressing Issue #10

New input parameter is 'token' which should be set to ${{ github.token }} to reference the current repository. The tag created will be the taken from the version created in the ServiceNow App Repo.

New modules had to be added (octokit) to allow easy talking to the github repo.

@chiarng
Copy link
Member

chiarng commented Mar 25, 2021

image

That's a lot of new modules! Is there any way to specify just the ones you need from octokit? I'm not that familiar with the setup either, so perhaps this is the minimal set... What do other GitHub Actions that need octokit do?

@chiarng chiarng self-assigned this Mar 25, 2021
@phifogg
Copy link
Author

phifogg commented Mar 25, 2021

I could remove some modules and test files. Seems much better now.
Still quite a few, I guess I have updated some versions on the already existing modules triggering this.

@chiarng chiarng linked an issue Jun 1, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate a source control Tag after application publish
2 participants