Skip to content

Conversation

Its-Nmk
Copy link
Contributor

@Its-Nmk Its-Nmk commented Oct 22, 2025

PR Description:

replace this with your description

Pull Request Checklist

Overview

  • Put an x inside of the square brackets to check each item.
  • I have read and understood the CONTRIBUTING.md guidelines
  • My pull request has a descriptive title that accurately reflects the changes and the description has been filled in above.
  • I've included only files relevant to the changes described in the PR title and description
  • I've created a new branch in my forked repository for this contribution

Code Quality

  • My code is relevant to ServiceNow developers
  • My code snippets expand meaningfully on official ServiceNow documentation (if applicable)
  • I've disclosed use of ES2021 features (if applicable)
  • I've tested my code snippets in a ServiceNow environment (where possible)

Repository Structure Compliance

  • I've placed my code snippet(s) in one of the required top-level categories:
    • Core ServiceNow APIs/
    • Server-Side Components/
    • Client-Side Components/
    • Modern Development/
    • Integration/
    • Specialized Areas/
  • I've used appropriate sub-categories within the top-level categories
  • Each code snippet has its own folder with a descriptive name

Documentation

  • I've included a README.md file for each code snippet
  • The README.md includes:
    • Description of the code snippet functionality
    • Usage instructions or examples
    • Any prerequisites or dependencies
    • (Optional) Screenshots or diagrams if helpful

Restrictions

  • My PR does not include XML exports of ServiceNow records
  • My PR does not contain sensitive information (passwords, API keys, tokens)
  • My PR does not include changes that fall outside the described scope

@Its-Nmk
Copy link
Contributor Author

Its-Nmk commented Oct 22, 2025

@ravichandra1998g - Added the changes again in a correct way following the existing predefined structure, Please review and merge.

Please do let me know if anything needs to be changed.

@ravichandra1998g ravichandra1998g self-assigned this Oct 22, 2025
Removed Hacktoberfest 2025 section and License information from README.
@Its-Nmk Its-Nmk requested a review from wiz0floyd October 22, 2025 11:44
@ravichandra1998g
Copy link
Contributor

Hello @Its-Nmk
Please make the above changes...

@Its-Nmk
Copy link
Contributor Author

Its-Nmk commented Oct 22, 2025

@ravichandra1998g - I have done the changes, please verify.

Copy link
Contributor

@ravichandra1998g ravichandra1998g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can still see the script in the Readme file

Comment on lines 31 to 46
// Script:
(function executeRule(current, previous /*null when async*/) {
if (new GlideImpersonate().isImpersonating()) { // Check if the user is impersonating
if (current.comments.changes() || current.work_notes.changes()) { // Check if comments or work notes have changed
let actualUserName = gs.getImpersonatingUserDisplayName();
let impersonatedUserName = gs.getUserDisplayName();
let logMessage = `User Impersonation Activity Detected:
Timestamp : ${ new GlideDateTime()}
Actual User: ${actualUserName}
Impersonated User: ${impersonatedUserName}
Comments added: ${current.comments || 'NA'}
Work Notes added: ${current.work_notes || 'NA'}`;
gs.info(logMessage);
}
}
})(current, previous);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do not need to add the script again in a Readme file.
Can you please remove this part too...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravichandra1998g - I have removed the code but just having a placeholder for script to highlight that we need to add a code in BR.

Copy link
Contributor

@ravichandra1998g ravichandra1998g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now

@ravichandra1998g ravichandra1998g merged commit 011e42d into ServiceNowDevProgram:main Oct 22, 2025
1 check passed
@Its-Nmk Its-Nmk deleted the user-impersonation-activity-logger branch October 22, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants