Addition Settings to control Prefetch and MaxConcurrent Calls (threads) #12
Conversation
Auto Merge
Sanitize QueueNames instead of removing MqPrefix
…aults to 0 the azure default) RegisterHandler allows the number of threads to be set and modifies the OnMessage's MaxConcurrentCalls Update README.md to reflect these changes
|
Can you confirm that this doesn't break existing Service Bus tests? you can change it to use your Azure Service Bus by populating the Although ideally every PR should include a test that tests the feature it adds. |
|
I'll work on adding some tests as well as some other items I'd like to see
added.
…On Sat, Apr 28, 2018 at 10:33 PM Demis Bellot ***@***.***> wrote:
Can you that this doesn't break existing Service Bus tests? you can change
it to use your Azure Service Bus by populating the
AZURE_BUS_CONNECTION_STRING environment variable with the connection
string to your Azure Service Bus instance.
Although ideally every PR should include a test that tests the feature it
adds.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#12 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABzyAgbxZ3NobTxQwaRl-DXMOOTuBngjks5ttTSGgaJpZM4TrDba>
.
|
|
I'm coming back to this after a break. @mythz Do you have some suggestions on how to test this besides the existing tests? This is a config of the underlying client so it isn't adding or modifying the functionality of the library only providing some configuration options to help better control the underlying throughput options. Quite frankly without being able to modify those values this MQ client is extremely slow at about 100 messages per minute (handling) across 10 threads. |
|
The commits just shouldn't break existing tests. You'll also need to update to the latest master before sending another PR as this PR now has conflicts. |
|
@sbosell, this is a useful feature for some of the work we are doing. Can I help you with this PR in anyway? |
Without being able to modify the prefetch and max concurrent calls the Service Bus clients can not be optimized. I added one setting for the MqServer in addition to the connection string to set the prefetch counts as well as the code to handle the number of threads on the RegisterHanders. Updated documentation/readme.