Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial fix for Android studio bug using add reference. #36

Merged
merged 8 commits into from
Jan 3, 2021

Conversation

Layoric
Copy link
Member

@Layoric Layoric commented Dec 22, 2020

Upgrade IDEA plugin to require/target at least 2019.3 onwards.

Still needs work to likely fix CI workflow as well as dev workflow so it is easy to target specific IDE and debug the plugin.

Will undraft once those are both working.

Small fixes to gradle to avoid kotlin warnings which is related to a still outstanding bug.
…lij` has a gradle `wrapper` task already setup. This I think downloads the associated grade? See -> https://github.com/JetBrains/gradle-intellij-plugin/blob/master/build.gradle.kts#L162

So these no longer need to be kept in source control for ease of CI builds (I think).
Delete gradle files as they should be seeded automatically since new gradle jetbrains intellij plugin update.
…J requires all writes to be done on UI thread or via "invokeLater" per write. With the current structure, this causes an issue writing maven dependencies (updating the pom.xml) as we need to edit the pom.xml twice.

Will need to consolidate writing options based on state to write once before reenabling async runnable.
@Layoric
Copy link
Member Author

Layoric commented Dec 24, 2020

Still need to do some final testing and some more clean up but will merge + release an update shortly after that.

@Layoric Layoric marked this pull request as ready for review December 27, 2020 01:02
@Layoric
Copy link
Member Author

Layoric commented Dec 27, 2020

Android studio and intellij working. Will fix Kotlin native support in separate PR.

@Layoric Layoric merged commit 288b667 into master Jan 3, 2021
@Layoric Layoric deleted the ssidea-2019-update branch January 3, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant