Removed unused weaver.Instance type. #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spetrovic77
approved these changes
Jul 13, 2023
This PR removes the unused `weaver.Instance` type. I believe that `weaver.Instance` became obsolete when we introduced `weaver.InstanceOf[T]`. Note that onlineboutique was using `weaver.Instance`, but not in a meaningful way.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the unused
weaver.Instancetype. I believe thatweaver.Instancebecame obsolete when we introducedweaver.InstanceOf[T].Note that onlineboutique was using
weaver.Instance, but not in a meaningful way.