Use a small traces table for querying. #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggested by @ghemawat. The traces table now contains only the information requied for querying. The new format is more space efficient and leads to faster querying. Also, insert all trace data into the database in a single transaction, as it is significantly more efficient: Before: cpu: Intel(R) Xeon(R) Gold 6154 CPU @ 3.00GHz BenchmarkStore BenchmarkStore/1 BenchmarkStore/1-72 100 10763759 ns/op BenchmarkStore/10 BenchmarkStore/10-72 10 108713097 ns/op BenchmarkStore/100 BenchmarkStore/100-72 1 1055861276 ns/op After: BenchmarkStore BenchmarkStore/1 BenchmarkStore/1-72 100 10609201 ns/op BenchmarkStore/10 BenchmarkStore/10-72 100 10700368 ns/op BenchmarkStore/100 BenchmarkStore/100-72 96 13052743 ns/op
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested by @ghemawat.
The traces table now contains only the information requied for querying. The new format is more space efficient and leads to faster querying.
Also, insert all trace data into the database in a single transaction, as it is significantly more efficient:
Before:
cpu: Intel(R) Xeon(R) Gold 6154 CPU @ 3.00GHz
BenchmarkStore
BenchmarkStore/1
BenchmarkStore/1-72 100 10763759 ns/op
BenchmarkStore/10
BenchmarkStore/10-72 10 108713097 ns/op
BenchmarkStore/100
BenchmarkStore/100-72 1 1055861276 ns/op
After:
BenchmarkStore
BenchmarkStore/1
BenchmarkStore/1-72 100 10609201 ns/op
BenchmarkStore/10
BenchmarkStore/10-72 100 10700368 ns/op
BenchmarkStore/100
BenchmarkStore/100-72 96 13052743 ns/op