Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the runtime perfetto/ package into traces/. #472

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Conversation

spetrovic77
Copy link
Contributor

Some deployers may wish to use the trace database without relying on the Perfetto UI.

Other changes:

  • Move the ReadSpan into the traces/ package, as we now send the proto across the wire, and some deployers (e.g,. GKE, Kube) will want to convert back to the OTel ReadOnlySpan format.
  • Move the perfetto UI code into a separate file.
  • Minor cleanups.

Some deployers may wish to use the trace database without relying
on the Perfetto UI.

Other changes:
  * Move the ReadSpan into the traces/ package, as we now send
    the proto across the wire, and some deployers (e.g,. GKE, Kube)
    will want to convert back to the OTel ReadOnlySpan format.
  * Move the perfetto UI code into a separate file.
  * Minor cleanups.
@spetrovic77 spetrovic77 requested a review from rgrandl July 19, 2023 17:37
@spetrovic77 spetrovic77 self-assigned this Jul 19, 2023
Copy link
Contributor

@rgrandl rgrandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spetrovic77 spetrovic77 merged commit 4800bb6 into main Jul 19, 2023
@spetrovic77 spetrovic77 deleted the trace2 branch July 19, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants