Dim attributes in pretty printed logs. #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spetrovic77
approved these changes
Aug 4, 2023
mwhittaker
force-pushed
the
remoteweavelet_logging
branch
from
46795ad to
5fe3a36
Compare
Before this PR, log attribute names were purple and attribute values were white. This PR dims both a light gray. This draws more attention to the body of the log compared to the attributes. I think we were also putting way too much stuff in the attributes which was making the logs hard to read. In theory, you can use attributes to query logs, but I don't think we ever did this. And even if we did, the attributes we had were awkward to query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, log attribute names were purple and attribute values were white. This PR dims both a light gray. This draws more attention to the body of the log compared to the attributes.
I think we were also putting way too much stuff in the attributes which was making the logs hard to read. In theory, you can use attributes to query logs, but I don't think we ever did this. And even if we did, the attributes we had were awkward to query.