Added unit tests for remote weavelet. #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spetrovic77
approved these changes
Aug 21, 2023
| d.t.Fatalf("A(%d): got %d, want %d", want, got, want) | ||
| } | ||
|
|
||
| // Test component b. |
There was a problem hiding this comment.
Just for my understanding: are these tests necessary, given that there's a call chain A -> B -> C ?
There was a problem hiding this comment.
Good point, I don't think they're necessary. I removed them.
This PR adds unit tests for the remote weavelet. Specifically, it tests that the weavelet still operates correctly even when some of its interactions with the envelope fail. For example, the weavelet should retry failed ActivateComponent calls. A handful of the tests are currently failing because of "bugs" in the remote weavelet. I skipped the tests for now and will try to fix the bugs in future PRs. Fixing the bugs is a bit tricky because it's not always straightforward the best way to handle failures. For example, if a weavelet calls GetListenerAddress and receives an address that is already in use, should it keep retrying the GetListenerAddress? Or should it just self-terminate?
- Removed redundant component tests. - Added nolint directive to make linter happy. - Added TestLogger to avoid logging after a test ends.
mwhittaker
force-pushed
the
remoteweavelet_tests
branch
from
8c399c9 to
cc31f73
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for the remote weavelet. Specifically, it tests that the weavelet still operates correctly even when some of its interactions with the envelope fail. For example, the weavelet should retry failed ActivateComponent calls. A handful of the tests are currently failing because of "bugs" in the remote weavelet. I skipped the tests for now and will try to fix the bugs in future PRs.
Fixing the bugs is a bit tricky because it's not always straightforward the best way to handle failures. For example, if a weavelet calls GetListenerAddress and receives an address that is already in use, should it keep retrying the GetListenerAddress? Or should it just self-terminate?