Fixed RemoteWeavelet UpdateRoutingInfo bugs. #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spetrovic77
approved these changes
Aug 21, 2023
internal/weaver/remoteweavelet.go
Outdated
| routing := fmt.Sprint(req.RoutingInfo.Replicas) | ||
| if req.RoutingInfo.Local { | ||
| routing = "local" | ||
| name := "?" |
There was a problem hiding this comment.
Nice catch.
This is too magical, would the following make sense:
func (w *RemoteWeavelet) UpdateRoutingInfo(...) (...) {
if req.RoutingInfo == nil {
w.syslogger.Debug("nil RoutingInfo")
return nil, fmt.Errorf("nil RoutingInfo")
}
info := req.RoutingInfo
defer func() {
// assume info != nil
...
}()
...
mwhittaker
force-pushed
the
remoteweavelet_tests
branch
from
8c399c9 to
cc31f73
Compare
This PR fixes four bugs in RemoteWeavelet's UpdateRoutingInfo. 1. Before this PR, UpdateRoutingInfo would panic if you passed it a nil RoutingInfo. This PR fixes UpdateRoutingInfo to instead return an error. 2. Recall that a component is either always local or always remote. We don't currently allow a component to switch between the two. This PR adds code to UpdateRoutingInfo to check this. 3. Before this PR, we were using the assignment from one component as the assignment for all components' load collectors. 4. UpdateRoutingInfo updates a resolver, balancer, and load collector. Before this PR, it was possible to update the load collector but not the resolver or balancer. This PR reorders things so either all are updated or none of them are. The update is still not transactional, as concurrent calls to UpdateRoutingInfo can interleave. We should consider fixing that in a future PR.
mwhittaker
force-pushed
the
update_routing_info_fixes
branch
from
3376e82 to
9c59642
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes four bugs in RemoteWeavelet's UpdateRoutingInfo.