Fixed period (".") app name bug. #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrandl
approved these changes
Aug 21, 2023
mwhittaker
force-pushed
the
app_name_bug
branch
from
3b0ee24 to
c9fa399
Compare
Before this PR, if you go ran a Service Weaver app with a config file that was missing an app name and a binary, the app name would erroneously default to ".". ``` ╭──────────────────────────────────────────────────╮ │ DEPLOYMENTS │ ├─────┬──────────────────────────────────────┬─────┤ │ APP │ DEPLOYMENT │ AGE │ ├─────┼──────────────────────────────────────┼─────┤ │ . │ 10695f3a-0afe-4361-8d9a-033fd6ea81a0 │ 2s │ ╰─────┴──────────────────────────────────────┴─────╯ ╭────────────────────────────────────────────────╮ │ COMPONENTS │ ├─────┬────────────┬──────────────┬──────────────┤ │ APP │ DEPLOYMENT │ COMPONENT │ REPLICA PIDS │ ├─────┼────────────┼──────────────┼──────────────┤ │ . │ 10695f3a │ weaver.Main │ 2417098 │ │ . │ 10695f3a │ collatz.Even │ 2417098 │ │ . │ 10695f3a │ collatz.Odd │ 2417098 │ │ . │ 10695f3a │ main │ 2417098 │ ╰─────┴────────────┴──────────────┴──────────────╯ ╭──────────────────────────────────────────────╮ │ LISTENERS │ ├─────┬────────────┬──────────┬────────────────┤ │ APP │ DEPLOYMENT │ LISTENER │ ADDRESS │ ├─────┼────────────┼──────────┼────────────────┤ │ . │ 10695f3a │ collatz │ 127.0.0.1:9000 │ ╰─────┴────────────┴──────────┴────────────────╯ ``` To calculate the app name, we called `filepath.Base` on the binary, but if the binary was empty, `filepath.Base` would return `"."`. This PR fixes the bug by only setting the app name if the binary is present.
mwhittaker
force-pushed
the
app_name_bug
branch
from
c9fa399 to
f56e259
Compare
The weird thing about |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, if you go ran a Service Weaver app with a config file that was missing an app name and a binary, the app name would erroneously default to ".".
To calculate the app name, we called
filepath.Baseon the binary, but if the binary was empty,filepath.Basewould return".". This PR fixes the bug by only setting the app name if the binary is present.