Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify registered listeners when starting the app. #561

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Verify registered listeners when starting the app. #561

merged 1 commit into from
Aug 23, 2023

Conversation

spetrovic77
Copy link
Contributor

This ensures that the application listeners match the information stored in the read-only section of the application binary, and used by various deployers. If there is a mismatch, the user will be prompted to run weaver generate.

This fixes one of the common issues that came up in workshops, where people forgot to re-run weaver generate after declaring the listener.

Copy link
Member

@mwhittaker mwhittaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks Srdjan!

dev/build_and_test Show resolved Hide resolved
validate.go Outdated Show resolved Hide resolved
validate.go Outdated Show resolved Hide resolved
validate_test.go Outdated Show resolved Hide resolved
internal/tool/generate/generator.go Show resolved Hide resolved
This ensures that the application listeners match the information
stored in the read-only section of the application binary, and used
by various deployers. If there is a mismatch, the user will be prompted
to run `weaver generate`.

This fixes one of the common issues that came up in workshops, where
people forgot to re-run `weaver generate` after declaring the listener.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants