Add a graph library and use it to represent the component call-graph. #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This graph library is based on an earlier C++ implementation by
ghemawat@.
The binary package now returns a component call-graph, as opposed to
returning a set of component edges. This fixes the following bug we
ran into multiple times:
* The program contains only the `weaver.Main` component.
* The set of component edges is therefore empty.
* The deployer iterates over the edges, and ends up ignoring
`weaver.Main` component.
The graph package will be handy in the future, as we plan to perform a
Topo-sort traversal of the graph when generating Kubernetes YAML files.
Also, the package may be useful for detecting component-graph cycles.
ghemawat
approved these changes
Sep 21, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This graph library is based on an earlier C++ implementation by ghemawat@.
The binary package now returns a component call-graph, as opposed to returning a set of component edges. This fixes the following bug we ran into multiple times:
weaver.Maincomponent.weaver.Maincomponent.The graph package will be handy in the future, as we plan to perform a Topo-sort traversal of the graph when generating Kubernetes YAML files. Also, the package may be useful for detecting component-graph cycles.