Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: lint-staged command 오류를 수정합니다. #73

Merged
merged 3 commits into from
Nov 28, 2024
Merged

bugfix: lint-staged command 오류를 수정합니다. #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
938d1ce
fix: fix lint-staged command error
jungwoo3490 Nov 28, 2024
4f1e992
chore: update biome config to use javascript.formatter.trailingcommas
jungwoo3490 Nov 28, 2024
dcba679
fix(mobile): fix lint error
jungwoo3490 Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apps/mobile/app/select-time/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
"use client";

import SelectTimeOptionSelect from "../../components/SelectTimeOptionSelect";
import { SelectModeType, SelectTimeOptionType } from "./type";
import { MobileIconDraw, MobileIconDrawChoose, MobileIconErase, MobileIconEraseChoose } from "@setaday/icon";
import { useState } from "react";
import SelectTimeOptionSelect from "../../components/SelectTimeOptionSelect";
import type { SelectModeType, SelectTimeOptionType } from "./type";

export default function Page() {
const [selectTimeOption, setSelectTimeOption] = useState<SelectTimeOptionType>("myTime");
Expand Down Expand Up @@ -38,10 +38,10 @@ export default function Page() {
<SelectTimeOptionSelect selectTimeOption={selectTimeOption} handleSelectOption={handleSelectOption} />
{selectTimeOption === "myTime" && (
<div className="flex h-[3.4rem] items-center gap-[0.6rem]">
<button onClick={handleClickWriteButton}>
<button type="button" onClick={handleClickWriteButton}>
{selectMode === "write" ? <MobileIconDrawChoose /> : <MobileIconDraw />}
</button>
<button onClick={handleClickEraseButton}>
<button type="button" onClick={handleClickEraseButton}>
{selectMode === "erase" ? <MobileIconEraseChoose /> : <MobileIconErase />}
</button>
</div>
Expand Down
7 changes: 3 additions & 4 deletions apps/mobile/components/SelectTimeHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import { MobileIconDonate, MobileIconSharing, MobileIconTeam, MobileLogo } from "@setaday/icon";
import Link from "next/link";
import React from "react";

function SelectTimeHeader() {
const handleClickDonateButton = () => {
Expand All @@ -23,13 +22,13 @@ function SelectTimeHeader() {
<MobileLogo />
</Link>
<div className="flex gap-[0.8rem]">
<button onClick={handleClickDonateButton}>
<button type="button" onClick={handleClickDonateButton}>
<MobileIconDonate />
</button>
<button onClick={handleClickTeamButton}>
<button type="button" onClick={handleClickTeamButton}>
<MobileIconTeam />
</button>
<button onClick={handleClickSharingButton}>
<button type="button" onClick={handleClickSharingButton}>
<MobileIconSharing />
</button>
</div>
Expand Down
44 changes: 22 additions & 22 deletions biome.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,25 @@
{
"$schema": "https://biomejs.dev/schemas/1.4.1/schema.json",
"organizeImports": {
"enabled": true
},
"linter": {
"enabled": true,
"rules": {
"recommended": true
}
},
"$schema": "https://biomejs.dev/schemas/1.4.1/schema.json",
"organizeImports": {
"enabled": true
},
"linter": {
"enabled": true,
"rules": {
"recommended": true
}
},
"formatter": {
"enabled": true,
"indentStyle": "space",
"indentWidth": 2,
"lineWidth": 120
},
"javascript": {
"formatter": {
"enabled": true,
"indentStyle": "space",
"indentWidth": 2,
"lineWidth": 120
},
"javascript": {
"formatter": {
"quoteStyle": "double",
"trailingComma": "es5",
"semicolons": "always"
}
"quoteStyle": "double",
"trailingCommas": "es5",
"semicolons": "always"
}
}
}
}
5 changes: 2 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,10 @@
"version-packages": "changeset version",
"release": "turbo run build && changeset publish",
"format": "biome format --write .",
"lint": "biome lint .",
"check": "biome check --apply ."
"lint": "biome lint ."
},
"lint-staged": {
"*.{js,jsx,ts,tsx}": "biome check --apply --format"
"*.{js,jsx,ts,tsx}": "biome check --no-errors-on-unmatched"
},
"devDependencies": {
"@biomejs/biome": "^1.9.4",
Expand Down