Do not flush when it should be done elsewhere

Setono · Oct 7, 2024 · c176483 · c176483
1 parent 149b15c
commit c176483
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 15 deletions.
diff --git a/src/Modifier/OrderGiftCardAmountModifier.php b/src/Modifier/OrderGiftCardAmountModifier.php
@@ -4,7 +4,6 @@
 
 namespace Setono\SyliusGiftCardPlugin\Modifier;
 
-use Doctrine\Persistence\ObjectManager;
 use RuntimeException;
 use Setono\SyliusGiftCardPlugin\Model\AdjustmentInterface;
 use Setono\SyliusGiftCardPlugin\Model\GiftCardInterface;
@@ -16,13 +15,6 @@
  */
 final class OrderGiftCardAmountModifier implements OrderGiftCardAmountModifierInterface
 {
-    private ObjectManager $giftCardManager;
-
-    public function __construct(ObjectManager $giftCardManager)
-    {
-        $this->giftCardManager = $giftCardManager;
-    }
-
     public function decrement(OrderInterface $order): void
     {
         foreach ($order->getAdjustments(AdjustmentInterface::ORDER_GIFT_CARD_ADJUSTMENT) as $adjustment) {
@@ -41,8 +33,6 @@ public function decrement(OrderInterface $order): void
                 $giftCard->setAmount($giftCard->getAmount() - $amount);
             }
         }
-
-        $this->giftCardManager->flush();
     }
 
     public function increment(OrderInterface $order): void
@@ -56,8 +46,6 @@ public function increment(OrderInterface $order): void
                 $giftCard->enable();
             }
         }
-
-        $this->giftCardManager->flush();
     }
 
     private static function getGiftCard(OrderInterface $order, string $code): GiftCardInterface

diff --git a/src/Resources/config/services/modifier.xml b/src/Resources/config/services/modifier.xml
@@ -7,8 +7,6 @@
         <!-- Needs to be public because it is called from the state machine -->
         <service id="setono_sylius_gift_card.modifier.order_gift_card_amount"
                  class="Setono\SyliusGiftCardPlugin\Modifier\OrderGiftCardAmountModifier"
-                 public="true">
-            <argument type="service" id="setono_sylius_gift_card.manager.gift_card"/>
-        </service>
+                 public="true"/>
     </services>
 </container>