Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Add/Remove GC to/from order #145

Merged
merged 8 commits into from
Sep 1, 2021

Conversation

Roshyo
Copy link
Contributor

@Roshyo Roshyo commented Aug 27, 2021

No description provided.

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #145 (9495824) into support-sylius-1-10 (47126f1) will increase coverage by 6.39%.
The diff coverage is 100.00%.

❗ Current head 9495824 differs from pull request most recent head b532c3a. Consider uploading reports for the commit b532c3a to get more accurate results
Impacted file tree graph

@@                    Coverage Diff                    @@
##             support-sylius-1-10     #145      +/-   ##
=========================================================
+ Coverage                  20.16%   26.55%   +6.39%     
- Complexity                   380      399      +19     
=========================================================
  Files                         70       77       +7     
  Lines                       1240     1303      +63     
=========================================================
+ Hits                         250      346      +96     
+ Misses                       990      957      -33     
Impacted Files Coverage Δ
src/Api/Command/AddGiftCardToOrder.php 100.00% <100.00%> (ø)
src/Api/Command/RemoveGiftCardFromOrder.php 100.00% <100.00%> (ø)
...c/Api/CommandHandler/AddGiftCardToOrderHandler.php 100.00% <100.00%> (ø)
.../CommandHandler/RemoveGiftCardFromOrderHandler.php 100.00% <100.00%> (ø)
...rc/Api/Controller/Action/GiftCardBalanceAction.php 100.00% <100.00%> (ø)
...r/GiftCardCodeAwareInputCommandDataTransformer.php 100.00% <100.00%> (ø)
...tionExtension/GiftCardsByLoggedInUserExtension.php 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47126f1...b532c3a. Read the comment docs.

@Roshyo Roshyo requested a review from loevgaard August 27, 2021 13:22
@Roshyo Roshyo changed the title Expose Add GC to order Expose Add/Remove GC to/from order Aug 27, 2021
@Roshyo Roshyo requested a review from loevgaard September 1, 2021 07:14
@Roshyo Roshyo requested a review from loevgaard September 1, 2021 07:34
Copy link
Member

@loevgaard loevgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@Roshyo Roshyo merged commit 443bc1a into support-sylius-1-10 Sep 1, 2021
@Roshyo Roshyo deleted the expose-add-gc-to-order branch September 1, 2021 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants