Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first Behat scenario for API #149

Merged
merged 3 commits into from
Sep 2, 2021
Merged

Conversation

Roshyo
Copy link
Contributor

@Roshyo Roshyo commented Sep 1, 2021

No description provided.

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #149 (5587906) into support-sylius-1-10 (9495824) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 5587906 differs from pull request most recent head a3b3fdb. Consider uploading reports for the commit a3b3fdb to get more accurate results
Impacted file tree graph

@@                  Coverage Diff                   @@
##             support-sylius-1-10     #149   +/-   ##
======================================================
  Coverage                  26.55%   26.55%           
  Complexity                   399      399           
======================================================
  Files                         77       77           
  Lines                       1303     1303           
======================================================
  Hits                         346      346           
  Misses                       957      957           
Impacted Files Coverage Δ
...rc/Api/Controller/Action/GiftCardBalanceAction.php 100.00% <100.00%> (ø)
...tionExtension/GiftCardsByLoggedInUserExtension.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 443bc1a...a3b3fdb. Read the comment docs.

Copy link
Member

@loevgaard loevgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check which services needs to be public? I am pretty sure it's only the pages or something

tests/Behat/Resources/api/clients.xml Outdated Show resolved Hide resolved
tests/Behat/Resources/context/api.xml Show resolved Hide resolved
tests/Behat/Resources/context/setup.xml Show resolved Hide resolved
@Roshyo
Copy link
Contributor Author

Roshyo commented Sep 1, 2021

Indeed, only the Contexts need to be public. Pages and api client can be private

@Roshyo Roshyo requested a review from loevgaard September 1, 2021 14:37
@Roshyo Roshyo merged commit f85c6c5 into support-sylius-1-10 Sep 2, 2021
@Roshyo Roshyo deleted the add-api-behat branch September 2, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants