Allow defining custom amounts for gift cards #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also allow defining custom message
Codecov Report
@@ Coverage Diff @@
## 0.12.x #154 +/- ##
============================================
+ Coverage 26.55% 34.61% +8.06%
- Complexity 399 436 +37
============================================
Files 77 84 +7
Lines 1303 1404 +101
============================================
+ Hits 346 486 +140
+ Misses 957 918 -39
Continue to review full report at Codecov.
|
loevgaard
requested changes
Sep 10, 2021
Co-authored-by: Joachim Løvgaard <joachim@loevgaard.dk>
…enh-configurable-gift-cards
Remove spec for Operator
loevgaard
reviewed
Sep 15, 2021
src/Resources/views/Shop/Product/Show/_addToCartGiftCardInformation.html.twig
Show resolved
Hide resolved
Remove un-needed methods signatures Remove un-needed default null property
Add Upgrade guide Remove un-needed template override
loevgaard
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also allow defining custom message