Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding first behat test for customizable gift card #155

Merged
merged 7 commits into from
Sep 29, 2021

Conversation

Roshyo
Copy link
Contributor

@Roshyo Roshyo commented Sep 15, 2021

No description provided.

@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #155 (3b5e30e) into 0.12.x (d2e3b54) will increase coverage by 1.71%.
The diff coverage is 95.12%.

❗ Current head 3b5e30e differs from pull request most recent head d101b6c. Consider uploading reports for the commit d101b6c to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             0.12.x     #155      +/-   ##
============================================
+ Coverage     34.61%   36.33%   +1.71%     
- Complexity      436      445       +9     
============================================
  Files            84       86       +2     
  Lines          1404     1445      +41     
============================================
+ Hits            486      525      +39     
- Misses          918      920       +2     
Impacted Files Coverage Δ
src/Form/Type/GiftCardType.php 0.00% <0.00%> (ø)
src/Api/Command/AddItemToCart.php 100.00% <100.00%> (ø)
src/Api/CommandHandler/AddItemToCartHandler.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2e3b54...d101b6c. Read the comment docs.

@Roshyo Roshyo marked this pull request as ready for review September 29, 2021 07:56
@Roshyo Roshyo force-pushed the adding-behat-custom-gc branch from 4af8955 to 4e97615 Compare September 29, 2021 08:36
@Roshyo Roshyo requested a review from loevgaard September 29, 2021 09:34
Co-authored-by: Joachim Løvgaard <joachim@loevgaard.dk>
@Roshyo Roshyo merged commit c5286ee into 0.12.x Sep 29, 2021
@Roshyo Roshyo deleted the adding-behat-custom-gc branch September 29, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants