Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Order eligible total provider to open up for easier overriding #161

Merged
merged 6 commits into from
Oct 1, 2021

Conversation

Roshyo
Copy link
Contributor

@Roshyo Roshyo commented Oct 1, 2021

No description provided.

@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #161 (81b8374) into 0.12.x (c5286ee) will increase coverage by 1.44%.
The diff coverage is 100.00%.

❗ Current head 81b8374 differs from pull request most recent head 6ab7f3c. Consider uploading reports for the commit 6ab7f3c to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             0.12.x     #161      +/-   ##
============================================
+ Coverage     36.33%   37.77%   +1.44%     
- Complexity      445      446       +1     
============================================
  Files            86       87       +1     
  Lines          1445     1448       +3     
============================================
+ Hits            525      547      +22     
+ Misses          920      901      -19     
Impacted Files Coverage Δ
src/OrderProcessor/OrderGiftCardProcessor.php 86.95% <100.00%> (+86.95%) ⬆️
src/Provider/OrderEligibleTotalProvider.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5286ee...6ab7f3c. Read the comment docs.

@Roshyo Roshyo requested a review from loevgaard October 1, 2021 07:20
@Roshyo Roshyo merged commit c850e0a into 0.12.x Oct 1, 2021
@Roshyo Roshyo deleted the add-order-total-provider branch October 1, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants