Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add valid until date #177

Merged
merged 14 commits into from
Jan 17, 2022
Merged

Add valid until date #177

merged 14 commits into from
Jan 17, 2022

Conversation

Roshyo
Copy link
Contributor

@Roshyo Roshyo commented Jan 10, 2022 •
edited
Loading

Fixes #169

  • Tests (unit/spec)
  • Danish translations
  • Validator for default period in admin

image
image

@codecov
Copy link

codecov bot commented Jan 10, 2022 •
edited
Loading

Codecov Report

Merging #177 (d3c44ef) into 0.12.x (92cbf10) will increase coverage by 2.14%.
The diff coverage is 73.41%.

Impacted file tree graph

@@             Coverage Diff              @@
##             0.12.x     #177      +/-   ##
============================================
+ Coverage     39.71%   41.85%   +2.14%     
- Complexity      457      483      +26     
============================================
  Files            88       92       +4     
  Lines          1483     1560      +77     
============================================
+ Hits            589      653      +64     
- Misses          894      907      +13
Impacted Files Coverage Δ
src/Form/Type/GiftCardConfigurationType.php 0.00% <0.00%> (ø)
src/Form/Type/GiftCardType.php 0.00% <0.00%> (ø)
...ator/Constraints/GiftCardIsNotExpiredValidator.php 87.50% <87.50%> (ø)
src/Form/Type/DatePeriodType.php 90.90% <90.90%> (ø)
src/Validator/Constraints/DatePeriodValidator.php 92.30% <92.30%> (ø)
src/Factory/GiftCardFactory.php 100.00% <100.00%> (ø)
src/Model/GiftCard.php 74.52% <100.00%> (+2.94%) ⬆️
src/Model/GiftCardConfiguration.php 81.25% <100.00%> (+14.58%) ⬆️
src/Provider/DatePeriodUnitProvider.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92cbf10...d3c44ef. Read the comment docs.

@loevgaard
Copy link
Member

loevgaard commented Jan 10, 2022 •
edited
Loading

Can you add some screenshots of the changes in admin?

@Roshyo Roshyo requested a review from loevgaard January 12, 2022 13:57
@Roshyo
Copy link
Contributor Author

Roshyo commented Jan 12, 2022

@loevgaard added one new translation, please update "da" file

@Roshyo Roshyo requested a review from loevgaard January 17, 2022 07:37
loevgaard
loevgaard approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@loevgaard loevgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 🎉

Roshyo and others added 10 commits January 17, 2022 10:56
Roshyo and others added 3 commits January 17, 2022 10:56
@Roshyo @loevgaard
Update src/Resources/translations/messages.da.yml
1a516cb 
Co-authored-by: Joachim Løvgaard <joachim@loevgaard.dk>
@Roshyo @loevgaard
Update src/Resources/translations/messages.da.yml
e1d820c 
Co-authored-by: Joachim Løvgaard <joachim@loevgaard.dk>
@Roshyo @loevgaard
Update src/Resources/translations/messages.da.yml
2dcc4f1 
Co-authored-by: Joachim Løvgaard <joachim@loevgaard.dk>
@Roshyo Roshyo force-pushed the 169-add-valid-until branch from 0f9d88e to 2dcc4f1 Compare January 17, 2022 09:56
@Roshyo Roshyo merged commit f0e5029 into 0.12.x Jan 17, 2022
@Roshyo Roshyo deleted the 169-add-valid-until branch January 17, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loevgaard loevgaard loevgaard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Roshyo @loevgaard