Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the background image validation #183

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Conversation

Roshyo
Copy link
Contributor

@Roshyo Roshyo commented Jan 15, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jan 15, 2022

Codecov Report

Merging #183 (cae52a2) into 0.12.x (a8dd0c4) will increase coverage by 1.49%.
The diff coverage is 100.00%.

❗ Current head cae52a2 differs from pull request most recent head 338d9aa. Consider uploading reports for the commit 338d9aa to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             0.12.x     #183      +/-   ##
============================================
+ Coverage     38.57%   40.06%   +1.49%     
- Complexity      454      455       +1     
============================================
  Files            88       88              
  Lines          1470     1470              
============================================
+ Hits            567      589      +22     
+ Misses          903      881      -22     
Impacted Files Coverage Δ
...idator/Constraints/HasBackgroundImageValidator.php 81.81% <100.00%> (+81.81%) ⬆️
src/Model/GiftCardConfiguration.php 66.66% <0.00%> (+21.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8dd0c4...338d9aa. Read the comment docs.

@Roshyo Roshyo force-pushed the ffix-background-image-validation branch from 4965159 to 3712779 Compare January 17, 2022 09:35
@Roshyo Roshyo merged commit 598716d into 0.12.x Jan 17, 2022
@Roshyo Roshyo deleted the ffix-background-image-validation branch January 17, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants