Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to define custom rendering options for wkhtmltopdf #185

Merged
merged 9 commits into from
Mar 18, 2022

Conversation

Roshyo
Copy link
Contributor

@Roshyo Roshyo commented Jan 17, 2022

Fixes #184

@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #185 (118fd47) into 0.12.x (170e50c) will increase coverage by 3.89%.
The diff coverage is 84.88%.

❗ Current head 118fd47 differs from pull request most recent head 8776ccb. Consider uploading reports for the commit 8776ccb to get more accurate results

@@             Coverage Diff              @@
##             0.12.x     #185      +/-   ##
============================================
+ Coverage     41.85%   45.75%   +3.89%     
- Complexity      483      501      +18     
============================================
  Files            92       94       +2     
  Lines          1560     1567       +7     
============================================
+ Hits            653      717      +64     
+ Misses          907      850      -57     
Impacted Files Coverage Δ
src/Form/Type/GiftCardConfigurationType.php 0.00% <0.00%> (ø)
src/Generator/GiftCardCodeGenerator.php 0.00% <0.00%> (ø)
src/DependencyInjection/Configuration.php 100.00% <100.00%> (ø)
...endencyInjection/SetonoSyliusGiftCardExtension.php 83.33% <100.00%> (+13.33%) ⬆️
src/Factory/GiftCardConfigurationFactory.php 100.00% <100.00%> (+100.00%) ⬆️
src/Generator/GiftCardPdfGenerator.php 100.00% <100.00%> (ø)
src/Model/GiftCardConfiguration.php 83.09% <100.00%> (+1.84%) ⬆️
src/Provider/PdfRenderingOptionsProvider.php 100.00% <100.00%> (ø)
...ator/Constraints/Pdf/ValidOrientationValidator.php 100.00% <100.00%> (ø)
...lidator/Constraints/Pdf/ValidPageSizeValidator.php 100.00% <100.00%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 170e50c...8776ccb. Read the comment docs.

@Roshyo Roshyo force-pushed the allow-pdf-rendering-options branch from 1765b83 to 9592a6b Compare January 26, 2022 12:27
@Roshyo Roshyo requested a review from loevgaard January 26, 2022 12:39
composer.json Outdated Show resolved Hide resolved
@loevgaard
Copy link
Member

Very nice PR, Stephane 🎉

psalm.xml Outdated Show resolved Hide resolved
@loevgaard loevgaard force-pushed the allow-pdf-rendering-options branch from 720a5a2 to ee84d16 Compare March 18, 2022 10:12
@loevgaard loevgaard merged commit a70f927 into 0.12.x Mar 18, 2022
@loevgaard loevgaard deleted the allow-pdf-rendering-options branch March 18, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants