Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ValidUntil to ExpiresAt #190

Merged
merged 2 commits into from
Jan 23, 2022
Merged

Rename ValidUntil to ExpiresAt #190

merged 2 commits into from
Jan 23, 2022

Conversation

Roshyo
Copy link
Contributor

@Roshyo Roshyo commented Jan 22, 2022

Fixes #189

@Roshyo Roshyo requested a review from loevgaard January 22, 2022 13:07
@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #190 (91b6736) into 0.12.x (f0e5029) will not change coverage.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             0.12.x     #190   +/-   ##
=========================================
  Coverage     41.85%   41.85%           
  Complexity      483      483           
=========================================
  Files            92       92           
  Lines          1560     1560           
=========================================
  Hits            653      653           
  Misses          907      907           
Impacted Files Coverage Δ
src/Form/Type/GiftCardType.php 0.00% <0.00%> (ø)
src/Factory/GiftCardFactory.php 100.00% <100.00%> (ø)
src/Model/GiftCard.php 74.52% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0e5029...91b6736. Read the comment docs.

Co-authored-by: Joachim Løvgaard <joachim@loevgaard.dk>
@Roshyo Roshyo merged commit ac0d118 into 0.12.x Jan 23, 2022
@Roshyo Roshyo deleted the rename-valid-until branch January 23, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants