Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow live pdf template edit #191

Merged
merged 28 commits into from
Mar 30, 2022
Merged

Allow live pdf template edit #191

merged 28 commits into from
Mar 30, 2022

Conversation

Roshyo
Copy link
Contributor

@Roshyo Roshyo commented Jan 22, 2022

Related to #187

image

composer.json Outdated Show resolved Hide resolved
@Roshyo Roshyo force-pushed the allow-live-pdf-template-edit branch from f387496 to 7a60bf1 Compare January 26, 2022 12:41
@Roshyo Roshyo marked this pull request as ready for review February 7, 2022 09:56
@Roshyo Roshyo force-pushed the allow-live-pdf-template-edit branch from a8ed585 to 5dcaa3b Compare February 7, 2022 09:57
@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #191 (3dab5e6) into 0.12.x (a70f927) will increase coverage by 2.74%.
The diff coverage is 78.64%.

❗ Current head 3dab5e6 differs from pull request most recent head 8acee4b. Consider uploading reports for the commit 8acee4b to get more accurate results

@@             Coverage Diff              @@
##             0.12.x     #191      +/-   ##
============================================
+ Coverage     45.75%   48.50%   +2.74%     
- Complexity      501      525      +24     
============================================
  Files            94      101       +7     
  Lines          1567     1670     +103     
============================================
+ Hits            717      810      +93     
- Misses          850      860      +10     
Impacted Files Coverage Δ
src/Form/Type/GiftCardConfigurationType.php 0.00% <0.00%> (ø)
src/Generator/GiftCardCodeGenerator.php 100.00% <ø> (+100.00%) ⬆️
src/Twig/Extension/PdfExtension.php 0.00% <0.00%> (ø)
src/Twig/Extension/PdfRuntime.php 37.50% <37.50%> (ø)
...r/Action/Admin/GenerateEncodedExamplePdfAction.php 100.00% <100.00%> (ø)
...ontroller/Action/Admin/LoadDefaultPdfCssAction.php 100.00% <100.00%> (ø)
...endencyInjection/SetonoSyliusGiftCardExtension.php 84.21% <100.00%> (+0.87%) ⬆️
src/Factory/GiftCardFactory.php 100.00% <100.00%> (ø)
src/Generator/GiftCardPdfGenerator.php 100.00% <100.00%> (ø)
src/Generator/GiftCardPdfPathGenerator.php 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a70f927...8acee4b. Read the comment docs.

@Roshyo Roshyo requested a review from loevgaard February 8, 2022 06:06
@Roshyo Roshyo force-pushed the allow-live-pdf-template-edit branch from b6346b9 to b935ec3 Compare March 4, 2022 08:05
@Roshyo Roshyo requested a review from loevgaard March 4, 2022 09:24
@Roshyo Roshyo requested a review from loevgaard March 9, 2022 07:22
@Roshyo Roshyo force-pushed the allow-live-pdf-template-edit branch from a7fe2f6 to e8075eb Compare March 28, 2022 15:18
@Roshyo Roshyo merged commit 58fb92d into 0.12.x Mar 30, 2022
@Roshyo Roshyo deleted the allow-live-pdf-template-edit branch March 30, 2022 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants