-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow preventing sending the notification email on GC creation #219
Conversation
Codecov Report
@@ Coverage Diff @@
## 0.12.x #219 +/- ##
============================================
+ Coverage 49.73% 50.32% +0.59%
- Complexity 528 532 +4
============================================
Files 102 102
Lines 1687 1699 +12
============================================
+ Hits 839 855 +16
+ Misses 848 844 -4
Continue to review full report at Codecov.
|
src/Resources/views/Admin/GiftCard/Create/_javascripts.html.twig
Outdated
Show resolved
Hide resolved
src/Resources/public/setono-sylius-gift-card-send-notification-email.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Joachim Løvgaard <joachim@loevgaard.dk>
Co-authored-by: Joachim Løvgaard <joachim@loevgaard.dk>
997bcd6
to
6960fbe
Compare
I think what this PR is missing is the case where an administrator updates a gift card, but doesn't change the email, then the user would get an email notification again. This could easily be solved, I think, by just having the |
Fixes #205