Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upping robustness #252

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Upping robustness #252

merged 2 commits into from
Oct 9, 2023

Conversation

loevgaard
Copy link
Member

No description provided.

@loevgaard loevgaard changed the title Fix deps Upping robustness Oct 9, 2023
@loevgaard loevgaard force-pushed the deps branch 3 times, most recently from 27c2d90 to cc45325 Compare October 9, 2023 08:24
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (56e3342) 41.55% compared to head (3a20884) 41.52%.

❗ Current head 3a20884 differs from pull request most recent head d57f7b0. Consider uploading reports for the commit d57f7b0 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             0.12.x     #252      +/-   ##
============================================
- Coverage     41.55%   41.52%   -0.04%     
- Complexity      590      592       +2     
============================================
  Files           108      108              
  Lines          2103     2105       +2     
============================================
  Hits            874      874              
- Misses         1229     1231       +2     
Files Coverage Δ
...rc/Controller/Action/DownloadGiftCardPdfAction.php 0.00% <ø> (ø)
src/DependencyInjection/Configuration.php 100.00% <ø> (ø)
src/Form/Type/AddGiftCardToOrderType.php 0.00% <ø> (ø)
src/Model/GiftCardBalanceCollection.php 40.74% <ø> (ø)
.../Action/UploadGiftCardConfigurationImageAction.php 96.42% <87.50%> (-3.58%) ⬇️
...endencyInjection/SetonoSyliusGiftCardExtension.php 86.20% <0.00%> (-3.08%) ⬇️
...zer/Normalizer/GiftCardConfigurationNormalizer.php 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@loevgaard loevgaard merged commit 2d4a156 into 0.12.x Oct 9, 2023
14 checks passed
@loevgaard loevgaard deleted the deps branch October 9, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant