Updated to Codeigniter 4 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeunMatt
reviewed
Oct 8, 2022
| @@ -525,7 +469,7 @@ private function prepareRawFileName($fileNameInBase64) { | |||
|
|
|||
| //let's determine what the current log file is | |||
| if(!is_null($fileNameInBase64) && !empty($fileNameInBase64)) { | |||
| $currentFile = $this->logFolderPath . "/". basename(base64_decode($fileNameInBase64)); | |||
| $currentFile = $this->logFolderPath . basename(base64_decode($fileNameInBase64)); | |||
There was a problem hiding this comment.
Are you certain $this->logFolderPath is going to end in / all the time? I'll say we should do a check if $this->logFolderPath ends with a / or not
There was a problem hiding this comment.
You can check that all CI4 paths (APPPATH, SYSTEMPATH, ROOTPATH, ... ) are explicitly defined with a trailing directory separator, and they are concatenated everywhere in the code assuming this, so seems to be kind of the path convention.
However if you want we can add this to make life easier to users.
SeunMatt
reviewed
Oct 8, 2022
Co-authored-by: Seun Matt <smatt382@gmail.com>
Co-authored-by: Seun Matt <smatt382@gmail.com>
Co-authored-by: Seun Matt <smatt382@gmail.com>
Co-authored-by: Seun Matt <smatt382@gmail.com>
|
Kudos @savioret please let me know when I can review again, thanks. |
|
I've finished. It's all yours. |
|
Sorry just found an error in the customization of viewName, it was wrongly named viewPath, it's fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review comments of #18 (comment)